-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: dreamweaver (original, plain, line) #1712
Conversation
Checked everywhere. Not sure what am I missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
You can ignore the failed optimizer check, it's failing due to permission issues.
My only suggestion is adding the full name as an altname
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fastest developer in the west 🤠
LGTM! ✔️
Thank you for another great contribution! 🙇
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one! ✔
Thank you for this contribution! 🚀
* new icon: dreamweaver (original, plain, line) * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> --------- Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
#1711
Link to prove your SVG is correct and up-to-date.
https://en.wikipedia.org/wiki/Adobe_Dreamweaver#/media/File:Adobe_Dreamweaver_CC_icon.svg