new icon: vitess (original, plain, original-wordmark, plain-wordmark) #1720

AbdelrahmanDwedar · 2023-04-02T05:15:23Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

the image used in their website source code

github-actions · 2023-04-02T05:23:04Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Error found in "devicon.json" for "vitess" entry: 
- Missing property key: "altnames".

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

AbdelrahmanDwedar · 2023-04-02T05:27:03Z

I forgot what are the options to use in SVGO. When someone check this PR can you tell me the needed options?

github-actions · 2023-04-02T05:29:28Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

AbdelrahmanDwedar · 2023-04-03T15:23:39Z

I did the optimization with SVGO but still there's a CI error. When someone checkout this PR can you tell me what did I miss?

Snailedlt · 2023-04-03T17:44:19Z

I did the optimization with SVGO but still there's a CI error. When someone checkout this PR can you tell me what did I miss?

The workflow that failed is not your fault. It's because it doesn't have access to your fork, so it fails. We're looking into it :)

AbdelrahmanDwedar · 2023-04-04T13:28:56Z

I did the optimization with SVGO but still there's a CI error. When someone checkout this PR can you tell me what did I miss?

The workflow that failed is not your fault. It's because it doesn't have access to your fork, so it fails. We're looking into it :)

Oh, alright no worries 👌🏼
I'll wait till you guys solve it.

lunatic-fox · 2023-04-08T12:15:27Z

icons/vitess/vitess-plain.svg

This icon version needs to be ungrouped and with only one path. Here's a suggestion:

Once this this icon will be used as font the colors will be added by devicon.json color property.

devicon.json

lunatic-fox · 2023-04-28T18:59:57Z

Panquesito7

It appears there are also wordmark versions.
It'd be great if you could add those to the list as well. 🙂

https://cncf-branding.netlify.app/projects/vitess/

AbdelrahmanDwedar · 2023-04-28T21:52:18Z

I'll try to do all that stuff tomorrow, sorry I'm in a exams time so I'll not be as active.

Snailedlt · 2023-05-16T18:52:43Z

@AbdelrahmanDwedar Good luck with your exams if you still have some upcoming :)
Let us know if you need any help with this PR

AbdelrahmanDwedar · 2023-05-18T21:43:41Z

It appears there are also wordmark versions. It'd be great if you could add those to the list as well. slightly_smiling_face

https://cncf-branding.netlify.app/projects/vitess/

This link breaks for me, but I found another one here
https://www.vectorlogo.zone/logos/vitessio/vitessio-ar21.svg

Panquesito7

The filename for the wordmark version should be original-wordmark.
It'd be great if you could add plain-wordmark as well.

If you need any help, let us know. 🙂

AbdelrahmanDwedar · 2023-05-20T02:25:19Z

I think this will work.

devicon.json

icons/vitess/vitess-plain-wordmark.svg

icons/vitess/vitess-original.svg

devicon.json

Co-authored-by: Josélio Júnior <[email protected]>

Co-authored-by: David Leal <[email protected]>

lunatic-fox · 2023-05-22T23:21:38Z

Color #f16827 will be added by color property of devicon.json.

lunatic-fox

Great work! ✔
Thank you for this contribution! 🚀

…devicons#1720) * add vitess original and plain icons * add vitess to the devicon.json * add no aliases to devicon.json * add no altname to devicon.json * fix position * optimize the icons with SVGO * Align `devicon.json` entry * Update devicon.json * Update `plain` version * add wordmark icon * fix: replace vitess-wordmark with vitess-original-wordmark * add vitess-plain-wordmark * Update color to `#f16827` Co-authored-by: Josélio Júnior <[email protected]> * Add new versions to devicon.json Co-authored-by: David Leal <[email protected]> * Add new font version to devicon.json Co-authored-by: David Leal <[email protected]> * fix original & plain-wordmark issues --------- Co-authored-by: Josélio Júnior <[email protected]> Co-authored-by: David Leal <[email protected]>

AbdelrahmanDwedar added 4 commits April 2, 2023 07:04

add vitess original and plain icons

c091499

add vitess to the devicon.json

f074bd2

Merge branch 'develop' into vitess

180b9f3

add no aliases to devicon.json

9992085

add no altname to devicon.json

92a2925

AbdelrahmanDwedar added 2 commits April 2, 2023 07:31

fix position

9ad1df5

optimize the icons with SVGO

4dd0053

Merge branch 'devicons:master' into vitess

5610212

lunatic-fox reviewed Apr 8, 2023

View reviewed changes

Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Apr 9, 2023

Align devicon.json entry

5255c71

lunatic-fox reviewed Apr 28, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

lunatic-fox added 3 commits April 28, 2023 15:53

Update devicon.json

d12b2f2

Update plain version

e95a813

Merge branch 'develop' into vitess

1800880

lunatic-fox requested review from Snailedlt, Panquesito7 and ConX April 28, 2023 19:00

Merge branch 'develop' into vitess

5969e01

Panquesito7 requested changes Apr 28, 2023

View reviewed changes

add wordmark icon

e7ba324

AbdelrahmanDwedar changed the title ~~new icon: vitess (original, plain)~~ new icon: vitess (original, plain, wordmark) May 18, 2023

AbdelrahmanDwedar requested review from Panquesito7 and lunatic-fox May 18, 2023 22:19

Panquesito7 requested changes May 20, 2023

View reviewed changes

AbdelrahmanDwedar added 2 commits May 20, 2023 04:23

fix: replace vitess-wordmark with vitess-original-wordmark

17fdcdf

add vitess-plain-wordmark

601a4a1

Panquesito7 changed the title ~~new icon: vitess (original, plain, wordmark)~~ new icon: vitess (original, plain, original-wordmark, plain-wordmark) May 21, 2023

Panquesito7 requested changes May 21, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

lunatic-fox requested changes May 21, 2023

View reviewed changes

icons/vitess/vitess-plain-wordmark.svg Outdated Show resolved Hide resolved

icons/vitess/vitess-original.svg Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

AbdelrahmanDwedar and others added 4 commits May 23, 2023 01:57

Update color to #f16827

25f320a

Co-authored-by: Josélio Júnior <[email protected]>

Add new versions to devicon.json

b6d375c

Co-authored-by: David Leal <[email protected]>

Add new font version to devicon.json

03c716b

Co-authored-by: David Leal <[email protected]>

fix original & plain-wordmark issues

5b590bd

Merge branch 'develop' into vitess

7192961

lunatic-fox requested a review from Panquesito7 May 22, 2023 23:23

lunatic-fox approved these changes May 22, 2023

View reviewed changes

Panquesito7 approved these changes May 23, 2023

View reviewed changes

Merge branch 'develop' into vitess

bc2b251

Panquesito7 merged commit e6d874f into devicons:develop May 23, 2023

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: vitess (original, plain, original-wordmark, plain-wordmark) #1720

new icon: vitess (original, plain, original-wordmark, plain-wordmark) #1720

AbdelrahmanDwedar commented Apr 2, 2023 •

edited

Loading

github-actions bot commented Apr 2, 2023

AbdelrahmanDwedar commented Apr 2, 2023

github-actions bot commented Apr 2, 2023

AbdelrahmanDwedar commented Apr 3, 2023

Snailedlt commented Apr 3, 2023

AbdelrahmanDwedar commented Apr 4, 2023

lunatic-fox Apr 8, 2023

lunatic-fox commented Apr 28, 2023

Panquesito7 left a comment

AbdelrahmanDwedar commented Apr 28, 2023

Snailedlt commented May 16, 2023

AbdelrahmanDwedar commented May 18, 2023

Panquesito7 left a comment

AbdelrahmanDwedar commented May 20, 2023

lunatic-fox commented May 22, 2023

lunatic-fox left a comment

new icon: vitess (original, plain, original-wordmark, plain-wordmark) #1720

new icon: vitess (original, plain, original-wordmark, plain-wordmark) #1720

Conversation

AbdelrahmanDwedar commented Apr 2, 2023 • edited Loading

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

github-actions bot commented Apr 2, 2023

AbdelrahmanDwedar commented Apr 2, 2023

github-actions bot commented Apr 2, 2023

AbdelrahmanDwedar commented Apr 3, 2023

Snailedlt commented Apr 3, 2023

AbdelrahmanDwedar commented Apr 4, 2023

lunatic-fox Apr 8, 2023

Choose a reason for hiding this comment

lunatic-fox commented Apr 28, 2023

Panquesito7 left a comment

Choose a reason for hiding this comment

AbdelrahmanDwedar commented Apr 28, 2023

Snailedlt commented May 16, 2023

AbdelrahmanDwedar commented May 18, 2023

Panquesito7 left a comment

Choose a reason for hiding this comment

AbdelrahmanDwedar commented May 20, 2023

lunatic-fox commented May 22, 2023

lunatic-fox left a comment

Choose a reason for hiding this comment

AbdelrahmanDwedar commented Apr 2, 2023 •

edited

Loading