Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: puppeteer (original, plain) #1808

Merged
merged 3 commits into from
Jul 21, 2023
Merged

new icon: puppeteer (original, plain) #1808

merged 3 commits into from
Jul 21, 2023

Conversation

Gautam25Raj
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1795

Link to prove your SVG is correct and up-to-date.

https://pptr.dev/

@Gautam25Raj
Copy link
Contributor Author

I have 2 icons for plain-wordmark. Let me know which looks better.

puppeteer-plain-wordmark puppeteer-plain-wordmark-2

@lunatic-fox
- Unify contour of original version
bfa1abb 
- Add alias of `original` and `plain` versions
@lunatic-fox lunatic-fox changed the title new icon: puppeteer (original-wordmark, plain-wordmark) new icon: puppeteer (original, plain) Jun 28, 2023
@lunatic-fox
Copy link
Contributor

I have 2 icons for plain-wordmark. Let me know which looks better.

puppeteer-plain-wordmark puppeteer-plain-wordmark-2

Another option:

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 4, 2023
@Panquesito7
Copy link
Member

I prefer the 2nd option. It's not fully black nor transparent.

@Gautam25Raj
Copy link
Contributor Author

I prefer the 2nd option. It's not fully black nor transparent.

Okay, lets move forward with the 2nd option. Its already been uploaded.

lunatic-fox
lunatic-fox reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! 👍🏼

Panquesito7
Panquesito7 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit afc45cd into devicons:develop Jul 21, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Gautam25Raj @lunatic-fox
new icon: puppeteer (original, plain) (devicons#1808)
a5bd39a 
* new icon: puppeteer (original-wordmark, plain-wordmark)

* - Unify contour of `original` version
- Add alias of `original` and `plain` versions

---------

Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox left review comments

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gautam25Raj @lunatic-fox @Panquesito7