Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Icon: Notion (Original) #1920

Merged
merged 17 commits into from
Oct 24, 2023
Merged

New Icon: Notion (Original) #1920

merged 17 commits into from
Oct 24, 2023

Conversation

Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented Oct 21, 2023

(Hacktobeberfest PR)

PR name matches the format new icon: Icon name (versions separated by a comma). More details here

PR's base is the develop branch.

Your icons are inside a folder as seen here

SVG matches the standards laid out here

A new object is added in the devicon.json file as seen here

This PR closes #1851

Link to prove your SVG is correct and up-to-date.

https://en.m.wikipedia.org/wiki/File:Notion-logo.svg

@Yashh56
Added
7daa39f 
New Icon
Notion
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 21, 2023

Hey Maintainer Please Review This PR

@Snailedlt Snailedlt changed the title [New Icon]: Notion(Original) New Icon: Notion (Original) Oct 21, 2023
Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the requested change, the icon also needs to be centered, and scaled so that there's no padding

devicon.json Outdated Show resolved Hide resolved
Yashh56 and others added 2 commits October 21, 2023 19:20
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 21, 2023 •
edited
Loading

Are these changes right @Snailedlt?

Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
Now we only need to add the font too (see the suggested changes)

devicon.json Outdated Show resolved Hide resolved
@Yashh56 @Snailedlt
Update devicon.json
b9e926d 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 21, 2023

Thank You @Snailedlt For The Help :)

Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this but it turns out the original icon can't be used as the plain icon after all. Take a look at my suggestion below for more info.

PS: Remember to update devicon.json to include the plain version after you've added it ;)

icons/notion/notion-original.svg Show resolved Hide resolved
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 21, 2023

@Snailedlt is these changes is ok ?

Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

icons/notion/notion-plain.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Yashh56 and others added 2 commits October 21, 2023 23:40
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 22, 2023

@Snailedlt is these changes are ok ?

Snailedlt
Snailedlt requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks good now. Just clean it up using SVGOMG, and remove the alias in devicon.json.
Here's a guide on how to clean up the icon: #1279 (comment)

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 22, 2023

Is This Is Ok @Snailedlt?

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 22, 2023

Can you add hacktoberfest label too @Snailedlt

Snailedlt
Snailedlt approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt requested review from a team, ConX, canaleal, lunatic-fox and Panquesito7 and removed request for a team October 22, 2023 11:47
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 22, 2023

What are these changes ?

@Snailedlt
Copy link
Collaborator

What are these changes ?

If you check the commit log you'll see the changes :)
In short it's this:

  1. Fix notion-plain.svg
  2. Add notion-line.svg and add it to devicon.json

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 22, 2023

Ok thanks for helping me @Snailedlt please add the hacktoberfest label too :)

@Snailedlt
Copy link
Collaborator

@Yashh56 I already added the hacktoberfest-accepted label. You should see this PR pop up on your hacktoberfest profile within 6hrs. Let me know if it doesn't show though :)

weh
weh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you 👍

@Snailedlt Snailedlt merged commit ef4f985 into devicons:develop Oct 24, 2023
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
@Yashh56 Yashh56 deleted the New-Icon-Notion branch February 6, 2024 03:38
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Yashh56 @Snailedlt
New Icon: Notion (Original) (devicons#1920)
c6affa7 
* Added
New Icon
Notion

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Update notion-original.svg

* Update notion-original.svg

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Added notion plain svg

* Updated devicon.json

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Update notion-plain.svg

* Update notion-plain.svg

* Update devicon.json

* Update notion-plain.svg

* Add line version

* join lines for plain version

* add newline

---------

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX

@canaleal canaleal Awaiting requested review from canaleal

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yashh56 @Snailedlt @weh