Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: threedsmax (original, plain) #1957

Merged
merged 2 commits into from
Nov 1, 2023
Merged

update icon: threedsmax (original, plain) #1957

merged 2 commits into from
Nov 1, 2023

Conversation

Snailedlt
Copy link
Collaborator

@Snailedlt Snailedlt commented Oct 30, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

This change is needed because 3dsmax was shorted to dsmax in the font. Probably because the filenames start with a number.
See #1952 (comment)

Link to prove your SVG is correct and up-to-date.

@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team October 30, 2023 11:50
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
canaleal
canaleal approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons and Json look good.

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2023
@Snailedlt Snailedlt merged commit 227ae39 into devicons:develop Nov 1, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Snailedlt
update icon: threedsmax (original, plain) (devicons#1957)
b1f430a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snailedlt @weh @canaleal