new icon: remix (original, original-wordmark, line, line-wordmark) #2150

AnshSinghSonkhia · 2024-02-17T04:29:12Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #2127

Link to prove your SVG is correct and up-to-date.

credits

Thanks to @weh

- plain - plain wordmark - line - line wordmark

weh

hi @AnshSinghSonkhia, thx for your contribution.
You need to check your SVG files according to https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards

The plain and line versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united. The color will be removed when being turned into icons so the .svg can have any color.
The SVG should be on a single line, with a following empty line
Check the Line version, to be a path, not strokes

devicon.json

Co-authored-by: Patrik Wehrli <[email protected]>

AnshSinghSonkhia · 2024-02-21T18:26:03Z

I made some changes @weh.
Kindly, guide me on any additional changes that you may need.

icons/remix/remix-plain.svg

icons/remix/remix-plain-wordmark.svg

devicon.json

flipped original & plain for base & alias

Changed color to #121212 Co-authored-by: Alex Canales <[email protected]>

canaleal

Nice, almost there. 👍
Now we gotta make sure to update the SVGs as they don't meet the standards layed out in the wiki.

Here's a tutorial on how to update the SVGs, and optimize them.

AnshSinghSonkhia · 2024-02-28T17:09:32Z

Nice, almost there. 👍 Now we gotta make sure to update the SVGs as they don't meet the standards layed out in the wiki.

Here's a tutorial on how to update the SVGs, and optimize them.

Thanks for sharing the tutorial @canaleal !!
I have updated the SVGs according to the standards!

canaleal

Excellent work 👍 Almost there.

Don't forget to that all the SVGs need to have 1 path only and must be optimized.

You can follow the tutorial I provided before on how to unify the paths and optimize the SVGs. The section is called Unify the Paths and create Plain Icons (Inkscape). You don't need to create plain icons, but make sure that the original svgs and the line svgs only have 1 path, 1 fill color, and the paths are not grouped.

Dont forget to optimize all the SVGs too using SVGOMG. You can also find this step in the tutorial.

AnshSinghSonkhia · 2024-02-29T15:06:41Z

Excellent work 👍 Almost there.

Don't forget to that all the SVGs need to have 1 path only and must be optimized.

You can follow the tutorial I provided before on how to unify the paths and optimize the SVGs. The section is called Unify the Paths and create Plain Icons (Inkscape). You don't need to create plain icons, but make sure that the original svgs and the line svgs only have 1 path, 1 fill color, and the paths are not grouped.

Dont forget to optimize all the SVGs too using SVGOMG. You can also find this step in the tutorial.

I successfully Unified the Paths according to the tutorial
But, Optimizing the SVG using SVGOMG is ruining the viewbox.

Is it necessary to optimizing the SVG for removing inkscape's attributes?

canaleal · 2024-02-29T15:16:46Z

Hey @AnshSinghSonkhia, yes. the SVGs have to be optimized.

Also, taking a look at the SVGs, there is more than 1 path for all SVGs,.

Original: 2 Paths and its still grouped.

Original-wordmark:

It's the same for the line SVGs.

If possible, could you post the SVG code after the optimizing it in SVGOMG.

AnshSinghSonkhia · 2024-02-29T16:51:23Z

Optimizing the SVG using SVGOMG

Optimizing is a 1 Click task with SVGVIEWER

I found it more easier to do with it.

Visit https://www.svgviewer.dev
Upload SVG or paste code

Click on Prettify Button.
Click on Optimize Button.

BOOM !!! The SVG is optimized, without ruining the viewbox.

canaleal · 2024-03-02T05:14:26Z

SVG Viewer is an awesome alternative, a previous contributor even recommended it, but notice how the SVGs still have the height, width and even stroke attributes after optimizing them in svg viewer.

And this is how it looks when I copied the original svg code from above into SVGOMG. The viewbox is still 0 0 128 128.

AnshSinghSonkhia · 2024-03-02T07:05:06Z

SVG Viewer is an awesome alternative, a previous contributor even recommended it, but notice how the SVGs still have the height, width and even stroke attributes after optimizing them in svg viewer.

<svg width="128" height="128" viewBox="0 0 128 128" fill="none" xmlns="http://www.w3.org/2000/svg"><path style="stroke-width:.270613;fill:#121212;fill-opacity:1" d="M8.389 0v26.09h55.445c14.656 0 21.986 6.29 21.986 16.67 0 11.804-7.33 16.263-21.986 16.263H8.389v26.663h53.818c11.603 0 17.912 3.255 18.93 17.91.77 10.01.674 14.965.582 19.718-.03 1.53-.06 3.038-.06 4.686h34.218c0-7.567 0-14.5-1.15-29.29-1.425-14.857-9.161-22.386-22.393-25.032 15.674-2.036 27.277-14.248 27.277-32.973C119.611 15.671 103.122 0 69.941 0zm0 108.125V128h43.535v-12.72c0-2.674-1.312-7.155-7.356-7.155z"/></svg>

And this is how it looks when I copied the original svg code from above into SVGOMG. The viewbox is still 0 0 128 128.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path fill="#121212" d="M8.389 0v26.09h55.445c14.656 0 21.986 6.29 21.986 16.67 0 11.804-7.33 16.263-21.986 16.263H8.389v26.663h53.818c11.603 0 17.912 3.255 18.93 17.91.77 10.01.674 14.965.582 19.718-.03 1.53-.06 3.038-.06 4.686h34.218c0-7.567 0-14.5-1.15-29.29-1.425-14.857-9.161-22.386-22.393-25.032 15.674-2.036 27.277-14.248 27.277-32.973C119.611 15.671 103.122 0 69.941 0zm0 108.125V128h43.535v-12.72c0-2.674-1.312-7.155-7.356-7.155z"/></svg>

Okay @canaleal, so what do you want me to do now, for the best results?

AnshSinghSonkhia · 2024-03-02T14:54:55Z

With SVGOMG

<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 128 128"><path fill="#121212" d="M8.389 0v26.09h55.445c14.656 0 21.986 6.29 21.986 16.67 0 11.804-7.33 16.263-21.986 16.263H8.389v26.663h53.818c11.603 0 17.912 3.255 18.93 17.91.77 10.01.674 14.965.582 19.718-.03 1.53-.06 3.038-.06 4.686h34.218c0-7.567 0-14.5-1.15-29.29-1.425-14.857-9.161-22.386-22.393-25.032 15.674-2.036 27.277-14.248 27.277-32.973C119.611 15.671 103.122 0 69.941 0zm0 108.125V128h43.535v-12.72c0-2.674-1.312-7.155-7.356-7.155z"/></svg>

I have not committed these changes, @canaleal

It is showing 150px height & width, Will it work?

canaleal · 2024-03-02T18:47:50Z

Yes, I just check the SVG code you provided in the comment above and it looks good on inkscape and icomoon.

AnshSinghSonkhia · 2024-03-04T14:53:09Z

Hey @canaleal & @weh,
The required changes are DONE. It's good to go, hopefully!!

I Got to learn a lot with this PR. Let me know if we need any more changes.

canaleal

Excellent work! 🚀
SVGs are good and properly optimized.

The font icons look good on icomoon, and there are no artifacts.

github-actions · 2024-03-05T05:19:59Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

AnshSinghSonkhia · 2024-03-08T05:04:35Z

Still, this pr has one pending review @canaleal

canaleal · 2024-03-08T06:47:34Z

Yup, thats pretty much the process. At least 2 reviewers are need to ensure that the changes are correct.

weh

LGTM 👍

github-actions · 2024-05-25T03:20:32Z

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

new icon: remix (original, original-wordmark, line, line-wordmark)

AnshSinghSonkhia added 2 commits February 17, 2024 09:45

Added: remix icons

fe2dda1

- plain - plain wordmark - line - line wordmark

Added: remix icons

816ff69

weh requested changes Feb 20, 2024

View reviewed changes

devicon.json Show resolved Hide resolved

AnshSinghSonkhia and others added 5 commits February 21, 2024 17:43

Updated: devicon.json

7b74abc

Co-authored-by: Patrik Wehrli <[email protected]>

Update remix-line-wordmark.svg

8bc7d30

Update remix-line.svg

45d0822

Update remix-plain.svg

bd8dbe0

Update remix-plain-wordmark.svg

ed9782c

AnshSinghSonkhia requested a review from weh February 21, 2024 18:23

canaleal requested changes Feb 22, 2024

View reviewed changes

AnshSinghSonkhia and others added 5 commits February 22, 2024 12:05

Rename remix-plain.svg to remix-original.svg

0442e55

Rename remix-plain-wordmark.svg to remix-original-wordmark.svg

19794cb

Updated devicon.json - flipped original & plain

1964ccd

flipped original & plain for base & alias

Updated devicon.json

9493d78

Changed color to #121212 Co-authored-by: Alex Canales <[email protected]>

Update devicon.json - added font array

bdfa037

AnshSinghSonkhia changed the title ~~new icon: remix (plain, plain-wordmark, line, line-wordmark)~~ new icon: remix (original, original-wordmark, line, line-wordmark) Feb 22, 2024

AnshSinghSonkhia requested a review from canaleal February 22, 2024 07:59

canaleal requested changes Feb 28, 2024

View reviewed changes

AnshSinghSonkhia added 5 commits February 28, 2024 22:24

Updated: remix-original with Inkscape

55cda37

Update: remix-original-wordmark with Inkscape

a8db324

Updated: remix-line with inkscape

f67876f

Updated: remix-line-wordmark with inkscape

91996d2

Merge branch 'develop' into remix

29467c7

AnshSinghSonkhia requested a review from canaleal February 28, 2024 17:12

canaleal requested changes Feb 28, 2024

View reviewed changes

Update: remix-original (1 Path)

1878bc6

AnshSinghSonkhia added 4 commits February 29, 2024 21:54

Optimized: remix-original.svg

18c5828

Optimized: remix-original-wordmark.svg

14e3097

Optimized: remix-line.svg

6a77964

Optimized: remix-line-wordmark.svg

1c9eb99

AnshSinghSonkhia requested a review from canaleal February 29, 2024 16:50

AnshSinghSonkhia added 4 commits March 3, 2024 10:27

Update: remix-original.svg with SVGOMG

d32fefb

Optimized: remix-original-wordmark using SVGOMG

7d9fd4c

Optimized: remix-line.svg using SVGOMG

609381b

Optimized: remix-line-wordmark using SVGOMG

e403469

Removed fill="none"

28660d5

canaleal previously approved these changes Mar 5, 2024

View reviewed changes

Removed trailing comma

bfa1b26

canaleal dismissed their stale review via bfa1b26 March 5, 2024 05:19

canaleal approved these changes Mar 5, 2024

View reviewed changes

canaleal mentioned this pull request Mar 8, 2024

new icon: filamentphp (original) #2122

Merged

6 tasks

weh approved these changes Apr 19, 2024

View reviewed changes

Merge branch 'develop' into remix

1f4f19b

canaleal merged commit 9da232a into devicons:develop May 25, 2024
5 checks passed

GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024

Merge pull request devicons#2150 from AnshSinghSonkhia/remix

268874b

new icon: remix (original, original-wordmark, line, line-wordmark)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: remix (original, original-wordmark, line, line-wordmark) #2150

new icon: remix (original, original-wordmark, line, line-wordmark) #2150

AnshSinghSonkhia commented Feb 17, 2024 •

edited

Loading

weh left a comment

AnshSinghSonkhia commented Feb 21, 2024

canaleal left a comment

AnshSinghSonkhia commented Feb 28, 2024

canaleal left a comment •

edited

Loading

AnshSinghSonkhia commented Feb 29, 2024

canaleal commented Feb 29, 2024

AnshSinghSonkhia commented Feb 29, 2024

canaleal commented Mar 2, 2024 •

edited

Loading

AnshSinghSonkhia commented Mar 2, 2024 •

edited

Loading

AnshSinghSonkhia commented Mar 2, 2024

canaleal commented Mar 2, 2024

AnshSinghSonkhia commented Mar 4, 2024

canaleal left a comment

github-actions bot commented Mar 5, 2024

AnshSinghSonkhia commented Mar 8, 2024

canaleal commented Mar 8, 2024

weh left a comment

github-actions bot commented May 25, 2024

new icon: remix (original, original-wordmark, line, line-wordmark) #2150

new icon: remix (original, original-wordmark, line, line-wordmark) #2150

Conversation

AnshSinghSonkhia commented Feb 17, 2024 • edited Loading

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

credits

weh left a comment

Choose a reason for hiding this comment

AnshSinghSonkhia commented Feb 21, 2024

canaleal left a comment

Choose a reason for hiding this comment

AnshSinghSonkhia commented Feb 28, 2024

canaleal left a comment • edited Loading

Choose a reason for hiding this comment

AnshSinghSonkhia commented Feb 29, 2024

canaleal commented Feb 29, 2024

AnshSinghSonkhia commented Feb 29, 2024

Optimizing is a 1 Click task with SVGVIEWER

canaleal commented Mar 2, 2024 • edited Loading

AnshSinghSonkhia commented Mar 2, 2024 • edited Loading

AnshSinghSonkhia commented Mar 2, 2024

With SVGOMG

It is showing 150px height & width, Will it work?

canaleal commented Mar 2, 2024

AnshSinghSonkhia commented Mar 4, 2024

canaleal left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2024

AnshSinghSonkhia commented Mar 8, 2024

canaleal commented Mar 8, 2024

weh left a comment

Choose a reason for hiding this comment

github-actions bot commented May 25, 2024

AnshSinghSonkhia commented Feb 17, 2024 •

edited

Loading

canaleal left a comment •

edited

Loading

canaleal commented Mar 2, 2024 •

edited

Loading

AnshSinghSonkhia commented Mar 2, 2024 •

edited

Loading