Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the peek script (bot:peek) take screenshot of individual files #412

Merged
merged 7 commits into from
Dec 30, 2020

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Dec 30, 2020

Hello,

This PR will give the peek workflow the ability to take screenshot of individual icons while in the browser. This will make it easier for us to spot issues as well.

You can see an example here at the very bottom of the PR #408. Once this PR is accepted, I will close that PR as well.

@amacado amacado added devops Use this label for devops related enhancements enhancement labels Dec 30, 2020
@amacado amacado changed the title Make the peek script take screenshot of individual files Make the peek script (bot:peek) take screenshot of individual files Dec 30, 2020
@Thomas-Boi
Copy link
Member Author

Hi @amacado ,

I've added your suggestions and error handling to this workflow. You can see an example of it in the test PR at the very bottom.

@amacado amacado mentioned this pull request Dec 30, 2020
@amacado
Copy link
Member

amacado commented Dec 30, 2020

@Thomas-Boi feel free to merge it once you are ready. We can have this in the v2.7.1 as well.

@Thomas-Boi Thomas-Boi merged commit 34a1866 into develop Dec 30, 2020
@amacado amacado deleted the TB_peekUpgrade branch December 30, 2020 21:31
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
 Make the peek script (bot:peek) take screenshot of individual files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bot:peek failing "UnhandledPromiseRejectionWarning: Error: Request failed with status code 403"
2 participants