Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING #416

Merged
merged 8 commits into from
Jan 1, 2021
Merged

Updated CONTRIBUTING #416

merged 8 commits into from
Jan 1, 2021

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Dec 30, 2020

Hello,

This should be the last update before we release a new version. I've added the new svg requirements and polish up a few sections.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Thomas-Boi
Copy link
Member Author

I hope the new term definition is clearer. I also made the .eps requirements optional

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses: devicons/[email protected] is not released yet, but soon so it's ok. Please have a look at the merge error :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Thomas-Boi
Copy link
Member Author

@amacado

The merge change has been fixed. I also changed some stuff in the python scripts so it fail instead of returning.

@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Jan 1, 2021

@amacado I've added the fix for #415 in this PR as well since we have to merge this anyway. Also, Happy New Year 🎉

@amacado amacado merged commit 4c397cf into develop Jan 1, 2021
@amacado amacado deleted the TB_contributing branch January 1, 2021 13:53
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants