Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove \n from script #511

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Remove \n from script #511

merged 2 commits into from
Feb 23, 2021

Conversation

Thomas-Boi
Copy link
Member

This should fix the issue #510

@Thomas-Boi Thomas-Boi requested a review from amacado February 23, 2021 04:26
@Thomas-Boi Thomas-Boi linked an issue Feb 23, 2021 that may be closed by this pull request
When you add more than two icons for the font versions, it adds up an \n in the GitHub comment #510
Closed
@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

0

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Panquesito7
Panquesito7 previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 apart from the above.

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

0

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Panquesito7
Panquesito7 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can be merged. 👍

@amacado amacado merged commit 173d070 into develop Feb 23, 2021
@amacado amacado deleted the thomas/feature/actionMessageUpdate branch February 23, 2021 07:11
This was referenced Feb 23, 2021
Merged
Closed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Thomas-Boi @Panquesito7
Remove \n from bot:peek workflow (devicons#511)
1eec160 
* Remove \n from script

* Update .github/workflows/post_peek_screenshot.yml

Co-authored-by: David Leal <[email protected]>

Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado amacado approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When you add more than two icons for the font versions, it adds up an \n in the GitHub comment
3 participants
@Thomas-Boi @amacado @Panquesito7