Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only build script will need token API #692

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Only build script will need token API #692

merged 1 commit into from
Jun 24, 2021

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Jun 24, 2021 •
edited
Loading

This fixes the issue seen in #691 with the peek bot.

Issue:

  • The script failed because the script requires a token command line arguments. However, peek bot does no need them.

Reason:

  • The build bot and peek bot share most of the same command line arguments. One of them, the token, was recently added and was meant for build bot only. However, I forgot to enforce that by accident.
  • The fix uses an existing check to ensure only the build bot requires the token

@Panquesito7 Panquesito7 added the bug Use this label for pointing out bugs label Jun 24, 2021
Panquesito7
Panquesito7 approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

@Panquesito7 Panquesito7 requested a review from amacado June 24, 2021 00:15
@Thomas-Boi Thomas-Boi added devops Use this label for devops related enhancements enhancement labels Jun 24, 2021
@Thomas-Boi Thomas-Boi merged commit 476f4eb into develop Jun 24, 2021
@amacado amacado deleted the thomas/argFix branch June 24, 2021 14:53
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Thomas-Boi
Merge pull request devicons#692 from devicons/thomas/argFix
5a08763 
Only build script will need token API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bug Use this label for pointing out bugs devops Use this label for devops related enhancements enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas-Boi @Panquesito7