Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Canva (original, plain) #710

Merged
merged 2 commits into from
Jul 2, 2021
Merged

new icon: Canva (original, plain) #710

merged 2 commits into from
Jul 2, 2021

Conversation

tupaschoal
Copy link
Contributor

@tupaschoal tupaschoal commented Jul 2, 2021 •
edited
Loading

Original:
canva-original

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 2, 2021
Panquesito7
Panquesito7 reviewed Jul 2, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both icons are one color only, so you could remove the plain version, and keep the original version, and add it as an alias (I can help you with that later).

icons/canva/canva-original.svg Outdated Show resolved Hide resolved
icons/canva/canva-plain.svg Outdated Show resolved Hide resolved
@tupaschoal
Copy link
Contributor Author

Just added it as an alias. Every now and then I'll also forget about the new lines x_x

@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @tupaschoal! Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 linked an issue Jul 2, 2021 that may be closed by this pull request
Icon request: [Canva] #546
Closed
@Panquesito7 Panquesito7 merged commit 34eb773 into devicons:develop Jul 2, 2021
@tupaschoal tupaschoal deleted the add-canva branch July 2, 2021 20:50
@devicons devicons deleted a comment from github-actions bot Jul 2, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@tupaschoal @Panquesito7
new icon: Canva (original, plain) (devicons#710)
971e6c8 
* Close devicons#546: Add Canva

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: [Canva]
2 participants
@tupaschoal @Panquesito7