new icon: processing (original, original-wordmark, plain, plain-wordmark) #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]>
…/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]>
…/lodash-4.17.21 Bump lodash from 4.17.20 to 4.17.21
Release v2.12.0
created new logo + text icon
Thomas-Boi
added
the
feature:icon
|
Hi @TheFoxarmy, Just a few things that I notice:
|
Panquesito7
requested changes
Jul 13, 2021
There was a problem hiding this comment.
As @Thomas-Boi said, please rename the processing-plain-text.svg file to processing-plain-wordmark.svg. Also rename the processing-original-text.svg file to processing-original-wordmark.svg.
Panquesito7
requested changes
Jul 13, 2021
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Panquesito7
changed the title
Panquesito7
added
the
bot:peek
This comment has been minimized.
This comment has been minimized.
Panquesito7
requested changes
Jul 13, 2021
Co-authored-by: David Leal <[email protected]>
Panquesito7
removed
the
bot:peek
Panquesito7
added
the
bot:peek
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Panquesito7
approved these changes
Jul 14, 2021
|
This PR looks good. Great job @TheFoxarmy! |
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
…ark) (devicons#747) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]> * Added nuxt icon from their design guide created new logo + text icon * Created plain version of nuxtjs & optimized original * removed unnecessary XML declarations. * Changed viewbox to 128x for all icons * Added plain processing icon * Vectorized processing icon * Added wordmark versions of processing icon & updated JSON * Added text versions, made minor change to put one line below others. * Renamed text to wordmark * optimized plain-wordmark Co-authored-by: David Leal <[email protected]> * optimized wordmark Co-authored-by: David Leal <[email protected]> * changed fonts to font Co-authored-by: David Leal <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <[email protected]> Co-authored-by: David Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #716
I used this image to create an SVG from scratch:
I'm not sure how to optimize the SVG too well since it has a lot of objects.
If the original is too busy, we can just use the plain version, though.
For the text versions, I've used black text, but I can make it white if preferred.