Feature: check-svg-bot upgrade #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Boi
force-pushed
the
thomas/feature/checkSvgUpdate
branch
from
330af58 to
8628380
Compare
Thomas-Boi
added
devops
amacado
approved these changes
Aug 13, 2021
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Clemens Bastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
This PR contains upgrades to the
check-svgbot. The bot will now:<style>tags in the SVG. Since the optimizer bot will prefix the classes with the file's name, the class name will be unique from now on => avoid issues of clashing class names from using multiple SVGs inline within HTML.Check forstroke-widthin the property and styles of the elements. After some testing, I found that Icomoon will warn us about strokes based on the presence of thestroke-widthproperty/style.Test: N/A
EDIT: I've removed the
stroke-widthcheck. Having it in would require refactoring the script to almost similar aspeek-bot. I think havingpeek-botchecking for strokes should be enough. Let me know what you guys think. If you think havingcheck-svgwarn them is better (since it's earlier), let me know.