Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README and CONTRIBUTING.md #808

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Conversation

Thomas-Boi
Copy link
Member

This PR contains minor updates to the README and CONTRIBUTING. It's mostly:

  • Explaining new standards (e.g. no need to optimize files)
  • Explaining new features (e.g. how to update an icon)
  • Clarification on existing features (e.g. develop vs master)
  • Minor fixes (e.g. missing entry in the table of contents)

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just some minor comments. 🙂

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@amacado amacado self-requested a review August 13, 2021 21:23
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your help in all of this, @Thomas-Boi! 😄👍🎉

@Thomas-Boi Thomas-Boi merged commit bdad7e4 into develop Aug 14, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
@Thomas-Boi Thomas-Boi deleted the thomas/feature/updateDocs branch August 23, 2021 23:56
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Update CONTRIBUTING

* Update README

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>

Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants