Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fundamental Security Issue #1

Closed
danielsmc opened this issue Feb 8, 2024 · 1 comment
Closed

Fundamental Security Issue #1

danielsmc opened this issue Feb 8, 2024 · 1 comment

Comments

@danielsmc
Copy link

Defining window.tabgod() doesn't just mean you can call it from devtools. It means that any JavaScript running on the page can call it. This, of course, completely destroys the same-origin policy that is central to browser security. If this is somehow the intended behavior, there should be a very prominent warning not to install this except in specialized development environments.

devidw added a commit that referenced this issue Feb 8, 2024
@devidw
Copy link
Owner

devidw commented Feb 8, 2024

I was only thinking from the development perspective, but not about the consequences this would have with every user having that api under the same name in the global scope - you're absolutely right.

0627531 moves the api from the global function to an options page and dev tools panel ui, instead of using external message passing its creating a port between only the extension and the service worker and not the user world anymore.

@devidw devidw closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants