You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm pretty sure this should be __dsp_currtask->state = DSPTASK_YIELD as that's what's done in the other yield cases. The corresponding bit in flags would be __dsp_currtask->flags = DSPTASK_CANCEL which seems wrong.
I don't know if this affects anything in practice.
The text was updated successfully, but these errors were encountered:
hey @Pokechu22 , sorry for this to take so long.
thanks for pointing that out!
it does indeed seem wrong to write the flags, instead of the state. seeing how its been in there for so long i don't think it had influence on much stuff, but it is more correct to write to state.
i merged the fix into libogc so with the next release it should be correct
libogc/libogc/dsp.c
Line 251 in 6c10421
I'm pretty sure this should be
__dsp_currtask->state = DSPTASK_YIELD
as that's what's done in the other yield cases. The corresponding bit inflags
would be__dsp_currtask->flags = DSPTASK_CANCEL
which seems wrong.I don't know if this affects anything in practice.
The text was updated successfully, but these errors were encountered: