Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP task code incorrectly sets flags instead of state in one case #130

Closed
Pokechu22 opened this issue Jun 22, 2022 · 1 comment · Fixed by #139
Closed

DSP task code incorrectly sets flags instead of state in one case #130

Pokechu22 opened this issue Jun 22, 2022 · 1 comment · Fixed by #139
Assignees

Comments

@Pokechu22
Copy link

__dsp_currtask->flags = DSPTASK_YIELD;

I'm pretty sure this should be __dsp_currtask->state = DSPTASK_YIELD as that's what's done in the other yield cases. The corresponding bit in flags would be __dsp_currtask->flags = DSPTASK_CANCEL which seems wrong.

I don't know if this affects anything in practice.

@DacoTaco
Copy link
Member

DacoTaco commented Feb 4, 2023

hey @Pokechu22 , sorry for this to take so long.
thanks for pointing that out!
it does indeed seem wrong to write the flags, instead of the state. seeing how its been in there for so long i don't think it had influence on much stuff, but it is more correct to write to state.
i merged the fix into libogc so with the next release it should be correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants