Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository url #111

Merged
merged 8 commits into from
Jul 22, 2020
Merged

Add repository url #111

merged 8 commits into from
Jul 22, 2020

Conversation

joacar
Copy link
Contributor

@joacar joacar commented Apr 17, 2020

Fix #109

Added

  • Get repository url from remote. Default is 'origin'. Can be configured via GitRemoteOrigin GitRemote

Proposal

  • Write full url "$(GitRepositoryUrl)/tree/$(Commit)" (default) that the assembly was built from

Task

  • Change GitRemoteOrigin to GitRemote
  • Default for GitRepositoryUrl? "http://localhost"
  • Handle failure getting url
  • Rebase before merge
  • Merge style (squash, rebase-fastforward, ..)
  • Add default remote name Set default origin early

@joacar
Copy link
Contributor Author

joacar commented Apr 17, 2020

Is there any way I can force generation of the static language files to check that they compile?

@joacar
Copy link
Contributor Author

joacar commented Apr 17, 2020

In CI build I can see that the value for the executed task to retrieve repository url is https://github.com/kzu/GitInfo.git. On my machine there is no trailing .git and I haven't seen it in other projects where I used this. Should we check if it's present and remove if so?
Perhaps not worth to bother with since it redirects to correct address. Could be potential issue with crawling and not following redirects.

@kzu
Copy link
Member

kzu commented Jul 22, 2020

Adding the .git suffix is optional when cloning the repository. I think it's fine.

This looks great, thanks a lot!

@kzu kzu merged commit e39339e into devlooped:master Jul 22, 2020
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Retrieve repository url
2 participants