F# support #93
Merged
F# support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… F# currently does not support the define preprocessor directive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add F# support.
It is missing the support for the metadata and the global namespace since as far as I can tell neither can be supported at the moment by F#.
It would be amazing if GitInfo had this support. Currently I work around the lack of F# support by creating a C# library that exposes the version information and reference that project from the F# project I want the versioning in.
Another difference is that I left the ThisAssembly public for F#. Testing locally it didn't appear to cause any problems with multiple projects referencing each other and using GitInfo. Let me know if I should change it to internal.