Initial work for standalone manifest per sponsorable account #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the boiler sample from https://github.com/kzu/Auth0Functions
The new message handler populates the access token in outgoing requests, as showcased in https://github.com/kzu/GitHubFunctions. The refactored code for the sponsorship inspection is now in the SponsorManager, so we remove all the rest from the function.
We use SponsorLink as a static helper class, so we shouldn't use that as a namespace anywhere.
This is what will tie together the local-only offline check against a one-time generated JWT signed manifest containing the same.
Makes tokens easier to inspect and troubleshoot, especially if the active user has multiple accounts being used simultaneously.
The devlooped/gh-sponsors repo will now just contain the extension for the GH CLI.
Also add default funding file to targets, initial test boilerplate for manifest endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll move to a self-hosted model where each sponsorable account can opt-in to using SL by:
gh sponsorsCLI to manage all manifestsThis removes the need for cross-sponsorable sync, issues around local-only manifest generation (and therefore, hacking) and others.
This brings the model back to a simpler approach, yet extensible enough that others can leverage it with minimal (although not non-existent) effort.