Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape invalid identifiers for file constants #249

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Escape invalid identifiers for file constants #249

merged 2 commits into from
Aug 30, 2023

Conversation

PhenX
Copy link
Contributor

@PhenX PhenX commented Aug 3, 2023

Fixes #83

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kzu kzu force-pushed the feature/escape-identifiers branch from f43e877 to aef8c2b Compare August 8, 2023 22:58
@kzu kzu enabled auto-merge (rebase) August 8, 2023 22:58
@kzu kzu force-pushed the feature/escape-identifiers branch 2 times, most recently from 0e9729f to 368da98 Compare August 8, 2023 23:06
@kzu
Copy link
Member

kzu commented Aug 8, 2023

It seems there are formatting issues. Please run the following commands and amend the commit:

dotnet format style -v:diag --exclude ~/.nuget
dotnet format whitespace  -v:diag --exclude ~/.nuget

@kzu kzu force-pushed the feature/escape-identifiers branch from 368da98 to 0b65595 Compare August 30, 2023 19:19
@kzu kzu force-pushed the feature/escape-identifiers branch from 22510b4 to d940aa4 Compare August 30, 2023 19:22
@kzu kzu merged commit f993401 into devlooped:main Aug 30, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ThisAssembly.Strings: If resource name is not a valid code identifier, compilation fails
3 participants
@PhenX @CLAassistant @kzu