Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attempts to retries #19

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Rename attempts to retries #19

merged 1 commit into from
Aug 7, 2024

Conversation

kzu
Copy link
Member

@kzu kzu commented Aug 7, 2024

Much easier to remember the arg name and understand what it's about. In code, we still use attempts.

Also, reduce retries to 3, seems like a more sensible default (total attempts = 4 therefore, one less than before).

Make the task description cleaner

@kzu kzu added the enhancement New feature or request label Aug 7, 2024
Much easier to remember the arg name and understand what it's about. In code, we still use attempts.

Also, reduce retries to 3, seems like a more sensible default (total attempts = 4 therefore, one less than before).

Make the task description cleaner
@kzu kzu enabled auto-merge (rebase) August 7, 2024 17:05
@devlooped-bot
Copy link
Member

devlooped-bot commented Aug 7, 2024

4 passed 4 passed

🧪 Details on Microsoft Windows 10.0.20348

✅ Sample.UnitTest1.FailsOnce
✅ Sample.UnitTest1.FailsTwice
✅ Sample.UnitTest1.Test1(value: 1)
✅ Sample.UnitTest1.Test1(value: 2)

from dotnet-retest v42.42.96-pr19 on .NET 8.0.7 with 💜

@kzu kzu merged commit 87a6ea7 into main Aug 7, 2024
9 checks passed
@kzu kzu deleted the dev/retries branch August 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants