Implement It.Is, It.IsIn, It.IsNotIn with a comparer overload #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weitzhandler
commented
Sep 29, 2020
weitzhandler
force-pushed
the
it-is-comparer
branch
3 times, most recently
from
6fa0f44 to
e3978f6
Compare
stakx
suggested changes
Sep 29, 2020
There was a problem hiding this comment.
Looks great, thanks! 👍
In addition to my review comments, please also add an entry to the CHANGELOG.md file, e.g. as follows:
The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
+
+## Unreleased
+
+#### Added
+
+* New method overloads for `It.Is`, `It.IsIn`, and `It.IsNotIn` that compare values using a custom `IEqualityComparer<T>` (@weitzhandler, #1064)
+
## 4.14.5 (2020-07-01)I've also included some review comments explicitly marked as "suggetions". If you choose not to follow them, I won't bother you about them again.
weitzhandler
force-pushed
the
it-is-comparer
branch
3 times, most recently
from
9e801e8 to
0cc2433
Compare
stakx
approved these changes
Sep 30, 2020
weitzhandler
force-pushed
the
it-is-comparer
branch
from
0cc2433 to
2442902
Compare
|
Yikes, my last edit applied those formatting again! Lemme rever that back. |
weitzhandler
force-pushed
the
it-is-comparer
branch
from
7570f40 to
b6b98f7
Compare
|
Ok fixed. Looks like it's ready to go. Thanks for your great effort @stakx, you're truly awesome! |
|
Still looking good, yes! FYI, it's probably going to take a few days until I'll merge this PR, as I'd like to first deal with #1061 and possibly do a patch release (4.14.6). This PR will go in 4.15.0 right afterward. 🚀 |
|
No worries, tx for the update, have a good one mate! |
|
I'm afraid I caused a merge conflict in |
|
Sure NP lemme rebase and merge. |
weitzhandler
force-pushed
the
it-is-comparer
branch
from
b6b98f7 to
f911802
Compare
|
Thanks @weitzhandler – this collaboration has been a breeze and very enjoyable! 👌 |
|
🙏 looking forward, thank you! |
mburumaxwell
pushed a commit
to faluapp/falu-dotnet
that referenced
this pull request
Jun 12, 2021
Bumps [Moq](https://github.com/moq/moq4) from 4.14.7 to 4.15.2. #Changelog *Sourced from [Moq's changelog](https://github.com/moq/moq4/blob/master/CHANGELOG.md).* > ## 4.15.2 (2020-11-26) > > #### Changed > > * Upgraded `System.Threading.Tasks.Extensions` dependency to version 4.5.4 (@JeffAshton, [#1108](devlooped/moq#1108)) > > > ## 4.15.1 (2020-11-10) > > #### Added > > * New method overloads for `It.Is`, `It.IsIn`, and `It.IsNotIn` that compare values using a custom `IEqualityComparer<T>` (@weitzhandler, [#1064](devlooped/moq#1064)) > * New properties `ReturnValue` and `Exception` on `IInvocation` to query recorded invocations return values or exceptions (@MaStr11, [#921](devlooped/moq#921), [#1077](devlooped/moq#1077)) > * Support for "nested" type matchers, i.e. type matchers that appear as part of a composite type (such as `It.IsAnyType[]` or `Func<It.IsAnyType, bool>`). Argument match expressions like `It.IsAny<Func<It.IsAnyType, bool>>()` should now work as expected, whereas they previously didn't. In this particular example, you should no longer need a workaround like `(Func<It.IsAnyType, bool>)It.IsAny<object>()` as originally suggested in [#918](devlooped/moq#918). (@stakx, [#1092](devlooped/moq#1092)) > > #### Changed > > * Event accessor calls (`+=` and `-=`) now get consistently recorded in `Mock.Invocations`. This previously wasn't the case for backwards compatibility with `VerifyNoOtherCalls` (which got implemented before it was possible to check them using `Verify{Add,Remove}`). You now need to explicitly verify expected calls to event accessors prior to `VerifyNoOtherCalls`. Verification of `+=` and `-=` now works regardless of whether or not you set those up (which makes it consistent with how verification usually works). (@80O, @stakx, [#1058](devlooped/moq#1058), [#1084](devlooped/moq#1084)) > * Portable PDB (debugging symbols) are now embedded in the main library instead of being published as a separate NuGet symbols package (`.snupkg) (@kzu, [#1098](devlooped/moq#1098)) > > #### Fixed > > * `SetupProperty` fails if property getter and setter are not both defined in mocked type (@stakx, [#1017](devlooped/moq#1017)) > * Expression tree argument not matched when it contains a captured variable – evaluate all captures to their current values when comparing two expression trees (@QTom01, [#1054](devlooped/moq#1054)) > * Failure when parameterized `Mock.Of<>` is used in query comprehension `from` clause (@stakx, [#982](devlooped/moq#982)) > > > ## 4.15.0 > > This version was accidentally published as 4.15.1 due to an intermittent problem with NuGet publishing. #Commits - [`f2aa090`](devlooped/moq@f2aa090) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1059.