Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and upload binlogs, don't version test build/run #230

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

kzu
Copy link
Member

@kzu kzu commented Sep 3, 2022

Since the test build/run step is run in pwsh, the expression
to set the version isn't working, but we don't need that anyway,
since pack will already pass the right version and will end
up causing a new build.

Since the test build/run step is run in pwsh, the expression
to set the version isn't working, but we don't need that anyway,
since `pack` will already pass the right version and will end
up causing a new build.
@kzu kzu enabled auto-merge (rebase) September 3, 2022 21:55
@kzu kzu merged commit 2decdff into main Sep 3, 2022
@kzu kzu deleted the dev/BuildBinlogs branch September 3, 2022 22:06
@devlooped devlooped locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant