Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jsonapi links #68

Merged
merged 7 commits into from
Jun 26, 2016
Merged

Conversation

MP0w
Copy link
Member

@MP0w MP0w commented Jun 25, 2016

Takes care of first two issues on #55

  • Properly support links on included resources
  • Clarify namings

@MP0w MP0w added this to the Beta-1 milestone Jun 25, 2016
@MP0w MP0w self-assigned this Jun 25, 2016
@codecov-io
Copy link

codecov-io commented Jun 25, 2016

Current coverage is 98.21%

Merging #68 into feature/JSONAPIRelationships will increase coverage by 0.11%

@@           feature/JSONAPIRelationships        #68   diff @@
==============================================================
  Files                                 6          7     +1   
  Lines                               369        393    +24   
  Methods                               0          0          
  Messages                              0          0          
  Branches                              0          0          
==============================================================
+ Hits                                362        386    +24   
  Misses                                7          7          
  Partials                              0          0          

Sunburst

Powered by Codecov. Last updated by f2be40e...c9b167a


import Foundation

public enum JSONAPILink: CustomSerializable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation missing

expect(links["testDog"]).to(equal("hello"))
}

it("should serialize the relationships links inside multiple relationships") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is now: "it should serialize relationships links" right?

@MP0w
Copy link
Member Author

MP0w commented Jun 26, 2016

👍

@joanromano joanromano force-pushed the feature/JSONAPILinks branch from c9b167a to 2b69b70 Compare June 26, 2016 13:42
@joanromano joanromano merged commit 2c3c9a1 into feature/JSONAPIRelationships Jun 26, 2016
@joanromano joanromano deleted the feature/JSONAPILinks branch June 26, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants