Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pathlib read_text function #242

Merged
merged 1 commit into from
Jun 24, 2021
Merged

added pathlib read_text function #242

merged 1 commit into from
Jun 24, 2021
+18 −3

Conversation

beliaev-maksim
Copy link
Member

pathlib.read_text should return string object. In our implementation that returns bytes.
I think the best will be to return response.text

@beliaev-maksim
added pathlib read_text function

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
183138c
@beliaev-maksim
Copy link
Member Author

this might also help in #135

@allburov allburov merged commit 6fa42f6 into devopshq:develop Jun 24, 2021
@beliaev-maksim beliaev-maksim mentioned this pull request Jul 7, 2021
Closed
@beliaev-maksim beliaev-maksim deleted the beliaev/read_text branch July 7, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allburov allburov

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beliaev-maksim @allburov