This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
chore: update node to 18.18.0 in tools container #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Svydenko <[email protected]>
l0rd
reviewed
Oct 4, 2023
Signed-off-by: Valeriy Svydenko <[email protected]>
l0rd
approved these changes
Oct 4, 2023
RomanNikitenko
approved these changes
Oct 4, 2023
Signed-off-by: Valeriy Svydenko <[email protected]>
svor
changed the title
|
well, you now depend on a version of node (18.18.0) that is newer than what's in ubi9/nodejs18 container. not a problem for online could be a problem for airgapped usage (?) |
it is used in the custom ansible image that doesn't work on AirGap env from the box. Since we don't build this image in brew, it shouldn't be a problem. Users should mirror it by hands if they want to have it in the cluster. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update node to 18.18.0 in ansible-creator-ee image because Che Code requires node >=18.15.x
To test that tasks a available with node 18, start a workspace by https://devspaces.apps.sandbox-stage.gb17.p1.openshiftapps.com/#/https://github.com/svor/ansible-devspaces-demo