Test cleanup (prebid#3238)

* stub pixel call in justpremium tests * properly stub geolocation services to prevent prompts * stub img creation as well to prevent call in justpremium
devunrulymedia · Jan 30, 2019 · 4c73c7b · 4c73c7b
1 parent 228b4d9
commit 4c73c7b
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 48 deletions.
diff --git a/modules/justpremiumBidAdapter.js b/modules/justpremiumBidAdapter.js
@@ -122,6 +122,16 @@ export const spec = {
 
 }
 
+export let pixel = {
+  fire(url) {
+    let img = document.createElement('img')
+    img.src = url
+    img.id = 'jp-pixel-track'
+    img.style.cssText = 'display:none !important;'
+    document.body.appendChild(img)
+  }
+};
+
 function track (data, payload, type) {
   let pubUrl = ''
 
@@ -147,11 +157,7 @@ ru=${encodeURIComponent(pubUrl)}&tt=&siw=&sh=${payload.sh}&sw=${payload.sw}&wh=$
 sd=&_c=&et=&aid=&said=&ei=&fc=&sp=&at=bidder&cid=&ist=&mg=&dl=&dlt=&ev=&vt=&zid=${payload.id}&dr=${duration}&di=&pr=&
 cw=&ch=&nt=&st=&jp=${encodeURIComponent(JSON.stringify(jp))}&ty=${type}`
 
-  let img = document.createElement('img')
-  img.src = pixelUrl
-  img.id = 'jp-pixel-track'
-  img.style.cssText = 'display:none !important;'
-  document.body.appendChild(img)
+  pixel.fire(pixelUrl);
 }
 
 function findBid (params, bids) {

diff --git a/test/spec/modules/justpremiumBidAdapter_spec.js b/test/spec/modules/justpremiumBidAdapter_spec.js
@@ -1,7 +1,19 @@
 import { expect } from 'chai'
-import { spec } from 'modules/justpremiumBidAdapter'
+import { spec, pixel } from 'modules/justpremiumBidAdapter'
 
 describe('justpremium adapter', function () {
+  let sandbox;
+  let pixelStub;
+
+  beforeEach(function() {
+    sandbox = sinon.sandbox.create();
+    pixelStub = sandbox.stub(pixel, 'fire');
+  });
+
+  afterEach(function() {
+    sandbox.restore();
+  });
+
   let adUnits = [
     {
       adUnitCode: 'div-gpt-ad-1471513102552-1',
@@ -132,7 +144,7 @@ describe('justpremium adapter', function () {
   })
 
   describe('onTimeout', function () {
-    it('onTimeout', (done) => {
+    it('onTimeout', function(done) {
       spec.onTimeout([{
         'bidId': '25cd3ec3fd6ed7',
         'bidder': 'justpremium',
@@ -153,7 +165,9 @@ describe('justpremium adapter', function () {
           'zone': 21521
         }],
         'timeout': 1
-      }])
+      }]);
+
+      expect(pixelStub.calledOnce).to.equal(true);
 
       done()
     })

diff --git a/test/spec/modules/uolBidAdapter_spec.js b/test/spec/modules/uolBidAdapter_spec.js
@@ -1,11 +1,20 @@
 import { expect } from 'chai';
 import { spec } from 'modules/uolBidAdapter';
-import { newBidder } from 'src/adapters/bidderFactory';
 
 const ENDPOINT = 'https://prebid.adilligo.com/v1/prebid.json';
 
 describe('UOL Bid Adapter', function () {
-  const adapter = newBidder(spec);
+  let sandbox;
+  let queryStub;
+  let getCurrentPositionStub;
+
+  beforeEach(function() {
+    sandbox = sinon.sandbox.create();
+  });
+
+  afterEach(function() {
+    sandbox.restore();
+  });
 
   describe('isBidRequestValid', function () {
     let bid = {
@@ -88,31 +97,6 @@ describe('UOL Bid Adapter', function () {
   });
 
   describe('buildRequests', function () {
-    let queryPermission;
-    let cleanup = function() {
-      navigator.permissions.query = queryPermission;
-    };
-    let grantTriangulation = function() {
-      queryPermission = navigator.permissions.query;
-      navigator.permissions.query = function(data) {
-        return new Promise((resolve, reject) => {
-          resolve({state: 'granted'});
-        });
-      }
-    };
-    let denyTriangulation = function() {
-      queryPermission = navigator.permissions.query;
-      navigator.permissions.query = function(data) {
-        return new Promise((resolve, reject) => {
-          resolve({state: 'prompt'});
-        });
-      }
-    };
-    let removeQuerySupport = function() {
-      queryPermission = navigator.permissions.query;
-      navigator.permissions.query = undefined;
-    }
-
     let bidRequests = [
       {
         'bidder': 'uol',
@@ -173,31 +157,42 @@ describe('UOL Bid Adapter', function () {
       describe('buildRequest geolocation param', function () { // shall only be tested if browser engine supports geolocation and permissions API.
         let geolocation = { lat: 4, long: 3, timestamp: 123121451 };
 
-        it('should contain user coordinates if (i) DNT is off; (ii) browser supports implementation; (iii) localStorage contains geolocation history', function () {
+        beforeEach(function() {
+          getCurrentPositionStub = sandbox.stub(navigator.geolocation, 'getCurrentPosition');
+          queryStub = sandbox.stub(navigator.permissions, 'query');
+        });
+
+        it('should not contain user coordinates if browser doesnt support permission query', function () {
           localStorage.setItem('uolLocationTracker', JSON.stringify(geolocation));
-          grantTriangulation();
+          navigator.permissions.query = undefined;
           const requestObject = spec.buildRequests(bidRequests, bidderRequest);
           const payload = JSON.parse(requestObject.data);
-          expect(payload.geolocation).to.exist.and.not.be.empty;
-          cleanup();
+          expect(payload.geolocation).to.not.exist;
         })
 
-        it('should not contain user coordinates if localStorage is empty', function () {
-          localStorage.removeItem('uolLocationTracker');
-          denyTriangulation();
+        it('should contain user coordinates if (i) DNT is off; (ii) browser supports implementation; (iii) localStorage contains geolocation history', function (done) {
+          localStorage.setItem('uolLocationTracker', JSON.stringify(geolocation));
+          queryStub.callsFake(function() {
+            return new Promise((resolve, reject) => {
+              resolve({state: 'granted'});
+            });
+          });
+          getCurrentPositionStub.callsFake(() => done());
           const requestObject = spec.buildRequests(bidRequests, bidderRequest);
           const payload = JSON.parse(requestObject.data);
-          expect(payload.geolocation).to.not.exist;
-          cleanup();
+          expect(payload.geolocation).to.exist.and.not.be.empty;
         })
 
-        it('should not contain user coordinates if browser doesnt support permission query', function () {
-          localStorage.setItem('uolLocationTracker', JSON.stringify(geolocation));
-          removeQuerySupport();
+        it('should not contain user coordinates if localStorage is empty', function () {
+          localStorage.removeItem('uolLocationTracker');
+          queryStub.callsFake(function() {
+            return new Promise((resolve, reject) => {
+              resolve({state: 'prompt'});
+            });
+          });
           const requestObject = spec.buildRequests(bidRequests, bidderRequest);
           const payload = JSON.parse(requestObject.data);
           expect(payload.geolocation).to.not.exist;
-          cleanup();
         })
       })
     }