Skip to content

Commit

Permalink
ci: remove extraneous imports lint rule as it doesnt work in monorepo…
Browse files Browse the repository at this point in the history
… setup

- it seems to be disabled by default for actual production .ts files;
  but the rule is in "error" mode for spec files.
- The rule doesn't seem to properly support mono-repos when configured properly.
i.e. it only considers the top-level package.json — hence doesn't deal with cross-workspace deps.
  • Loading branch information
devversion committed Dec 2, 2024
1 parent de9c862 commit b6a2f14
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"import/newline-after-import": "error",
"import/no-absolute-path": "error",
"import/no-duplicates": "error",
"import/no-extraneous-dependencies": ["off", { "devDependencies": false }],
"import/no-unassigned-import": ["error", { "allow": ["symbol-observable"] }],
"import/order": [
"error",
Expand Down Expand Up @@ -142,7 +141,6 @@
{
"files": ["!packages/**", "**/*_spec.ts"],
"rules": {
"import/no-extraneous-dependencies": ["error", { "devDependencies": true }],
"max-lines-per-function": "off",
"no-case-declarations": "off",
"no-console": "off"
Expand Down

0 comments on commit b6a2f14

Please sign in to comment.