fix(github-actions): improve error logging and fix ESM node resolution

We recently prioritized `module` over `main` but this results in browser code being prioritized sometimes. We revert that change and keep the original/default ESBuild main field order. This unveils an issue with `jsonc-parser` though- which ships an UMD file for `main` that cannot be bundled. We can work around this by processing `jsonc-parser`'s ESM output directly and then using that instead of leaving resolution to ESBuild for this package. There is an issue for this being tracked: microsoft/node-jsonc-parser#57
devversion · Oct 21, 2022 · c172725 · c172725
1 parent a67b584
commit c172725
Show file tree

Hide file tree

Showing 24 changed files with 120,370 additions and 110,196 deletions.
diff --git a/.github/local-actions/changelog/main.js b/.github/local-actions/changelog/main.js
diff --git a/bazel/esbuild/index.bzl b/bazel/esbuild/index.bzl
@@ -29,7 +29,6 @@ def esbuild_esm_bundle(name, **kwargs):
 
     args = dict(
         resolveExtensions = [".mjs", ".js", ".json"],
-        mainFields = ["module", "main"],
         outExtension = {".js": ".mjs"},
         # Workaround for: https://github.com/evanw/esbuild/issues/1921.
         banner = {

diff --git a/github-actions/auth-app.d.ts b/github-actions/auth-app.d.ts
@@ -0,0 +1 @@
+export * from '@octokit/auth-app';
diff --git a/github-actions/commit-message-based-labels/lib/main.ts b/github-actions/commit-message-based-labels/lib/main.ts
@@ -93,7 +93,7 @@ class CommitMessageBasedLabelManager {
 // to prevent the action from actually running in a fork of a repository with this action set up.
 if (context.repo.owner === 'angular') {
   CommitMessageBasedLabelManager.run().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

diff --git a/github-actions/commit-message-based-labels/main.js b/github-actions/commit-message-based-labels/main.js
diff --git a/github-actions/create-pr-for-changes/lib/main.ts b/github-actions/create-pr-for-changes/lib/main.ts
@@ -201,7 +201,7 @@ async function main(): Promise<void> {
     }
   } catch (err: any) {
     core.setOutput('result', ActionResult.failed);
-    core.error(err);
+    console.error(err);
     core.setFailed(err.message);
   }
 }

diff --git a/github-actions/create-pr-for-changes/main.js b/github-actions/create-pr-for-changes/main.js
diff --git a/github-actions/feature-request/main.js b/github-actions/feature-request/main.js
diff --git a/github-actions/google-internal-tests/lib/main.ts b/github-actions/google-internal-tests/lib/main.ts
@@ -97,6 +97,6 @@ async function findExistingTestStatus(
 }
 
 main().catch((e: Error) => {
-  core.error(e);
+  console.error(e);
   core.setFailed(e.message);
 });
diff --git a/github-actions/google-internal-tests/main.js b/github-actions/google-internal-tests/main.js
diff --git a/github-actions/jsonc-parser.d.ts b/github-actions/jsonc-parser.d.ts
diff --git a/github-actions/labels-sync/main.js b/github-actions/labels-sync/main.js
diff --git a/github-actions/lock-closed/lib/main.ts b/github-actions/lock-closed/lib/main.ts
@@ -115,7 +115,7 @@ async function runLockClosedAction(github: Octokit): Promise<void> {
 // Runs triggered via 'workflow_dispatch' are also allowed to run.
 if (context.repo.owner === 'angular' || context.eventName === 'workflow_dispatch') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

diff --git a/github-actions/lock-closed/main.js b/github-actions/lock-closed/main.js
diff --git a/github-actions/org-file-sync/main.js b/github-actions/org-file-sync/main.js
diff --git a/github-actions/post-approval-changes/lib/main.ts b/github-actions/post-approval-changes/lib/main.ts
@@ -136,7 +136,7 @@ async function runPostApprovalChangesAction(client: Octokit): Promise<void> {
 // Runs triggered via 'workflow_dispatch' are also allowed to run.
 if (context.repo.owner === 'angular') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {

diff --git a/github-actions/post-approval-changes/main.js b/github-actions/post-approval-changes/main.js
diff --git a/github-actions/slash-commands/lib/main.ts b/github-actions/slash-commands/lib/main.ts
@@ -121,7 +121,7 @@ async function runSlashCommandsAction(
 // to prevent the action from actually running in a fork of a repository with this action set up.
 if (context.repo.owner === 'angular') {
   main().catch((e: Error) => {
-    core.error(e);
+    console.error(e);
     core.setFailed(e.message);
   });
 } else {