Package as gem #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Print error when merge encounters a has_and_belongs_to_many relation. Seems to be broken for that type of relation - Update rspec and activerecord - Make code conform more closely to ruby style guide - Update Readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you are open to PRs but I've packaged this as a gem. I haven't published it yet because I would like someone to review it as I haven't packaged a gem before.
It also seems like the
has_and_belongs_to_manyrelation merging is broken. I could have broken it with my updates and refactorings or by using it with updated dependencies but I didn't touch the merge module other than making style changes rubocop suggested. It seems to be looking for foreign keys directly on the other objects and not on the merge table. This is causing 2 of the tests (relating to thehas_and_belongs_to_manyrelation) to fail.I added a condition that prints a warning that the current version doesn't support
has_and_belongs_to_manyrelations. If someone wants to figure out what is wrong or fix it, that should be removed before testing.