Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oidc accept groups as string #2562

Closed
wants to merge 2 commits into from

Conversation

susguzman
Copy link

Overview

The current OIDC connector only support the groups claim as an array, but if the response is a string, because the user only has one group, the groups cannot be mapped. I was configuring Dex with an OIDC provider that response a string when the user has only one group, so it's needed a way to handle this scenarios.

What this PR does / why we need it

  • Allows the group claim be a string and an array.
  • It's need because there are some providers that response with a string when the user only have one group.

Does this PR introduce a user-facing change?

NONE

OIDC Connector: Support for groups as a string.

@susguzman susguzman marked this pull request as ready for review June 21, 2022 22:48
@nabokihms
Copy link
Member

It seems ok to me to support converting a string to a group/groups.
@susguzman, could you please give us an example of the provider that responds with a string if a user has only one group?

@nabokihms
Copy link
Member

My bad, accidently linked unrelated PR.

@nabokihms
Copy link
Member

Closed by #2639

@nabokihms nabokihms closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants