Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to override checksum/config annotations #49

Closed
TeddyAndrieux opened this issue Jun 28, 2021 · 0 comments · Fixed by #52
Closed

Add ability to override checksum/config annotations #49

TeddyAndrieux opened this issue Jun 28, 2021 · 0 comments · Fixed by #52

Comments

@TeddyAndrieux
Copy link
Contributor

When we do not create the Dex secret using the helm chart (configSecret.create = false), we want to be able to override the checksum/config annotation so that it matches the content of the secret we use
TeddyAndrieux added a commit to scality/metalk8s that referenced this issue Jun 28, 2021
@TeddyAndrieux
chart,salt: Migrate from "stable/dex" to "dex/dex" helm chart
bf3d93e 
The "stable/dex" helm chart get deprecated so we just move to the
supported one from Dex repo.

```
rm -rf charts/dex
helm repo add dex https://charts.dexidp.io
helm repo update
helm fetch -d charts --untar dex/dex
```

Patch chart to add clusterIP support
See dexidp/helm-charts#48

Patch chart to use HTTPS in the Ingress
See dexidp/helm-charts#15

Patch chart to be able to override `checksum/config` annotation
See dexidp/helm-charts#49

Render chart to salt state using:

```
./charts/render.py dex \
  --namespace metalk8s-auth charts/dex.yaml \
  --service-config dex metalk8s-dex-config \
  metalk8s/addons/dex/config/dex.yaml.j2 metalk8s-auth \
  --kube-version 1.17 charts/dex \
  > salt/metalk8s/addons/dex/deployed/chart.sls
```

NOTE: We use `kube-version 1.17` as curently we embed Python Kubernetes
1.17 version
@TeddyAndrieux TeddyAndrieux mentioned this issue Jun 28, 2021
Merged
TeddyAndrieux added a commit to TeddyAndrieux/helm-charts that referenced this issue Jul 5, 2021
@TeddyAndrieux
Add ability to override checksum/config annotation
81e3578 
Fixes: dexidp#49
Signed-off-by: Teddy Andrieux <[email protected]>
@TeddyAndrieux TeddyAndrieux mentioned this issue Jul 5, 2021
Merged
TeddyAndrieux added a commit to TeddyAndrieux/helm-charts that referenced this issue Aug 30, 2021
@TeddyAndrieux
Do not set checksum/config annotation if we not create the secret
bd89d51 
Fixes: dexidp#49
Signed-off-by: Teddy Andrieux <[email protected]>
sagikazarmark pushed a commit to TeddyAndrieux/helm-charts that referenced this issue Aug 30, 2021
@TeddyAndrieux @sagikazarmark
Do not set checksum/config annotation if we not create the secret
4a715d6 
Fixes: dexidp#49
Signed-off-by: Teddy Andrieux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to override checksum/config annotation TeddyAndrieux/helm-charts
1 participant
@TeddyAndrieux