Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Update test snapshots 14-11-2024 #5389

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dfe-sdt
Copy link
Collaborator

@dfe-sdt dfe-sdt commented Nov 14, 2024

This PR was auto-generated on 14-11-2024 by create-pull-request due to visual differences identified

Copy link
Collaborator

@N-moh N-moh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct ?
17 datasets were deleted ?

@@ -1,5 +1,5 @@
{
"num_datasets": "959 data sets",
"num_datasets": "941 data sets",
"themes": [
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the number of datasets that have gone down from 959 to 941

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed now as the Higher Level Learners release 2022/23. That's dropped from 35 to 17 since the last release (2021/22).

Copy link

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop in number of data sets consistent with changes made by the Higher Level Learners publication team to their data collection.

And expected date changes for the 4 publications that went live this morning.

@@ -1,5 +1,5 @@
{
"num_datasets": "959 data sets",
"num_datasets": "941 data sets",
"themes": [
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed now as the Higher Level Learners release 2022/23. That's dropped from 35 to 17 since the last release (2021/22).

@N-moh
Copy link
Collaborator

N-moh commented Nov 14, 2024

Is this correct ? 17 datasets were deleted ?
This is correct and expected because one of the latest releases has fewer data sets

@N-moh N-moh merged commit 029c35d into dev Nov 14, 2024
8 checks passed
@N-moh N-moh deleted the chore/update-test-snapshots branch November 14, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants