EES-5656 Release series tidy up #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyoungman
reviewed
Dec 9, 2024
src/GovUk.Education.ExploreEducationStatistics.Admin/Requests/ReleaseSeriesItemRequests.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Outdated
Show resolved
Hide resolved
benoutram
force-pushed
the
EES-5656_Release_Series_Tidyup
branch
from
f7024c1 to
2ecefe3
Compare
benoutram
force-pushed
the
EES-5656_Release_Series_Tidyup
branch
from
2ecefe3 to
504166c
Compare
mmyoungman
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains mainly backend changes, separating out a few bits of tidy up ahead of the main changes in EES-5656.
There are two main changes amongst some other smaller improvements.
I attempted to remove
IdfromReleaseSeriesItem, thinking that in cases where a publication has no legacy releases it would be nice if theReleaseSeriesfield only contained an array of release id's. I backtracked on removing it entirely when I realised it's needed to be able to safely select the chosen legacy release from the release series array in the Admin UI when choosing to 'Edit' a legacy link. I've left in a lot of the changes where it doesn't need to be present though. For example, it's removed fromReleaseSeriesItemViewModelso it's no longer exposed to the public frontend. It's also removed fromReleaseSeriesItemUpdateRequestwhere supplying with each entry in the update made no difference, since we replace all the entries in the old value ofReleaseSerieswith an entirely new set of entries.I changed the building of the view model in
PublicationService.GetReleaseSeriesto be built from aReleaserather thanReleaseVersionwhich is possible now the fieldsTitleandSlughave moved toRelease. This also makes things a bit clearer in test code where we can compare fields in the view model with expected releases, rather than release versions.