EES-5719 Fix unique guidance title validation not triggering correctly #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily fixes a bug where the incorrect guidance titles from the other key stats was being passed to the validation in `EditableKeyStatDataBlockForm`. We now calculate the correct set of guidance titles by comparing all key stats with the current form's key stat.
ntsim
requested review from
bennettstuart,
rianski,
tomjonesdev and
amyb-hiveit
tomjonesdev
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes a bug where the incorrect guidance titles from the other key stats was being passed to the validation in
EditableKeyStatDataBlockForm. We now calculate the correct set of guidance titles by comparing all key stats with the current form's key stat.