EES-5689 - added various failure alerts #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-at-hiveit
force-pushed
the
EES-5689-add-bug-and-error-alerts
branch
from
4ace52e to
4a47bab
Compare
…App. Swapping noisy latency alerts for static ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This PR also makes the assumption that certain "failure" HTTP response codes are expected to happen from our application code and so are treated as a lower priority than unexpected ones. As an example, 403s are expected for failed authentication responses, whereas 401s aren't expected as our end-user interactions don't generally produce those whereas incorrectly configured infrastructure will.