Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping path check too strict #684

Closed
ben-edna opened this issue Mar 7, 2025 · 0 comments · Fixed by #685
Closed

Overlapping path check too strict #684

ben-edna opened this issue Mar 7, 2025 · 0 comments · Fixed by #685
Assignees
Labels
bug Something isn't working

Comments

@ben-edna
Copy link
Contributor

ben-edna commented Mar 7, 2025

Given this manifest:

 remotes:
  - name: git-mycompany
    url-base: [email protected]:mycompany/

  projects:
  - name: JsonParse
    dst: modules/JsonParse
    repo-path: modules/string
    src: Core/JsonParse

  - name: Json
    dst: modules/Json
    repo-path: modules/string
    src: Core/Json

The console shows:

Dfetch (0.9.1)
Multiple manifests found, using dfetch.yaml
  JsonParse           : Fetched feature/single-jsmn - b6bb2b9b23411271e246c7979d4c5879e334b333
  Json                : Skipping due to overlapping destination: "modules/Json"
There is already a project in "modules/Json" or one of its subfolders!
Each destination must be unique and not overlapping.

This is wrong, it should not look at overlapping names

@ben-edna ben-edna added the bug Something isn't working label Mar 7, 2025
@spoorcc spoorcc self-assigned this Mar 7, 2025
ben-edna added a commit that referenced this issue Mar 7, 2025
ben-edna added a commit that referenced this issue Mar 7, 2025
ben-edna added a commit that referenced this issue Mar 7, 2025
ben-edna added a commit that referenced this issue Mar 7, 2025
@spoorcc spoorcc closed this as completed in c23337c Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants