Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fmt::Display output for Status is now valid JSON #536

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ericswanson-dfinity
Copy link
Member

Description

Added a comma and newline in between fields.

Fixes https://dfinity.atlassian.net/browse/SDK-1457

How Has This Been Tested?

Tested locally with a modified dfx

$ cargo run ping ic
{
  "ic_api_version": "0.18.0",
  "replica_health_status": "healthy",
  "root_key": [48, 129, 130, 48, 29, 6, 13, 43, 6, 1, 4, 1, 130, 220, 124, 5, 3, 1, 2, 1, 6, 12, 43, 6, 1, 4, 1, 130, 220, 124, 5, 3, 2, 1, 3, 97, 0, 129, 76, 14, 110, 199, 31, 171, 88, 59, 8, 189, 129, 55, 60, 37, 92, 60, 55, 27, 46, 132, 134, 60, 152, 164, 241, 224, 139, 116, 35, 93, 20, 251, 93, 156, 12, 213, 70, 217, 104, 95, 145, 58, 12, 11, 44, 197, 52, 21, 131, 191, 75, 67, 146, 228, 103, 219, 150, 214, 91, 155, 180, 203, 113, 113, 18, 248, 71, 46, 13, 90, 77, 20, 80, 95, 253, 116, 132, 176, 18, 145, 9, 28, 95, 135, 185, 136, 131, 70, 63, 152, 9, 26, 11, 170, 174]
}

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner March 18, 2024 20:24
@ericswanson-dfinity ericswanson-dfinity enabled auto-merge (squash) March 18, 2024 20:31
@ericswanson-dfinity ericswanson-dfinity merged commit cb763d7 into main Mar 18, 2024
24 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/sdk-1457-status-output-commas branch March 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants