Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable chunked_wasm test #550

Merged
merged 7 commits into from
May 8, 2024
Merged

test: re-enable chunked_wasm test #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5670d62
re-enable the test with dfx 0.20.0-beta.0
lwshang Apr 25, 2024
4c63a9e
disable e2e on macos
lwshang Apr 25, 2024
762464f
macos-12
lwshang Apr 25, 2024
de13bcf
Merge branch 'main' into lwshang/sdk-1587
lwshang Apr 29, 2024
ce6e627
Merge branch 'main' into lwshang/sdk-1587
ericswanson-dfinity May 6, 2024
fc02977
latest dfx is 0.20.0 now
lwshang May 8, 2024
31b9e00
Merge branch 'main' into lwshang/sdk-1587
lwshang May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-12, windows-latest]

steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 0 additions & 5 deletions ref-tests/tests/ic-ref.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,11 +843,6 @@ mod management_canister {
#[ignore]
#[test]
fn chunked_wasm() {
// TODO: remove the following two lines to re-enable the test once dfx release (next of 0.19.0).
// The test is disabled because it requires updated replica which is not available in the latest dfx release (0.19.0).
// The correctness can be verified by relative tests in the sdk repo.
return;
#[allow(unreachable_code)]
with_agent(|agent| async move {
let wasm = b"\0asm\x01\0\0\0";
let wasm_hash = Sha256::digest(wasm).to_vec();
Expand Down