feat: dynamic routing mvp #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
approved these changes
Dec 13, 2024
| }; | ||
| use url::Url; | ||
|
|
||
| use crate::agent::AgentError; | ||
|
|
||
| use super::HttpService; | ||
| #[cfg(not(feature = "_internal_dynamic-routing"))] | ||
| pub(crate) mod dynamic_routing; |
There was a problem hiding this comment.
Should we make this pub? Otherwise DynamicRouteProviderBuilder can't be used to create a custom route_provider for the .with_arc_route_provider(). For the ic-gateway we should be able to do it.
There was a problem hiding this comment.
This is pub if you enable _internal_dynamic-routing, for internal use-cases like ic-gateway.
ic-agent/src/agent/route_provider/dynamic_routing/dynamic_route_provider.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the final interface of the dynamic routing feature as a wrapper around the draft implementation, since work on the final implementation has stalled. The draft implementation may or may not be replaced in the future.