-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stub for Bitcoin headers endpoint #297
feat: Add stub for Bitcoin headers endpoint #297
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor nitpicks. Also, I'd avoid linking to private documentation in the PR description as external readers can't access them. You can instead link to the public documentation: dfinity/interface-spec#298
As stated in here, candid interface should look as:
This PR will add no-op endpoint for returning the block headers in the follow-up we will implement specified function.