feat: Expose FuncVisitor
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chenyan-dfinity
approved these changes
Mar 22, 2022
ninegua
pushed a commit
to ninegua/candid
that referenced
this pull request
Apr 22, 2022
…ty#325) * fix: use provisional_create_canister_with_cycles for creating canisters and other QoL We should not allow people to run create_canister outside of its intended context (inter-canister calls). Since this library should only be used in clients, create_canister should really not be there. This pushes the release to be more 0.15.6 compatible. Also included is removing the install_code and create_canister call types, as those are deprecated since the introduction of the management canister. A bit overdue for a PR. * The matrix variable is called `spec`, not `icrefgitref` Co-authored-by: Joachim Breitner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Exposing this enables more customization in function serialization and helps get around #273.
Requirements
N/A
Considered Solutions
N/A
Recommended Solution
N/A
Considerations
Makes
FuncVisitora part of the public interface.