Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add functionality to ensure that at least one node from each operator is in use #1063

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

sasa-tomic
Copy link
Member

If a node operator does not have any node assigned to a subnet, we cannot know if these nodes are in good shape. When there is no reduction in decentralization (!), let's try to have at least one node of each operator in a subnet, since we will have better insights into node health.
The new functionality can be called with:

dre network --ensure-operator-nodes-assigned

Also, a few minor changes in the PR:

  • silence ic-admin notices since we are running it from automation
  • Refactor decentralization change handling, to make impact of a change on decentralization more consistent across operations
  • Rename the "heal" subcommand with "network --heal", but keep backwards compatibility. We may remove it at some point in the future

…erator is in use

If a node operator does not have any node assigned to a subnet, we cannot know if these nodes are in good shape. When there is no reduction in decentralization (!), let's try to have at least one node of each operator in a subnet, since we will have better insights into node health.
The new functionality can be called with:
```
dre network --ensure-operator-nodes-assigned
```

Also, a few minor changes in the PR:
- silence ic-admin notices since we are running it from automation
- Refactor decentralization change handling, to make impact of a change on decentralization more consistent across operations
- Rename the "heal" subcommand with "network --heal", but keep backwards compatibility. We may remove it at some point in the future
@sasa-tomic sasa-tomic requested a review from a team as a code owner November 8, 2024 17:20
@sasa-tomic sasa-tomic merged commit 23174fe into main Nov 11, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the sat-network-optimize-operator-probe-nodes branch November 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants