fix(release-controller): remove suppression of stdout and stderr in Git commands #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this PR involve the removal of the suppression of `stdout` and `stderr` for various Git commands in the `GitRepo` class and the `host-os-release-notes.py` script. This includes commands such as `checkout`, `fetch`, and `reset`, which now will output their standard messages and errors to the console. Impact: - Improved visibility of Git command outputs, aiding in debugging and understanding of the operations being performed by the application. - Reduced potential difficulties in diagnosing issues, as the immediate feedback from Git operations is now available.
sasa-tomic
changed the title
StephanusFischer
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR involve the removal of the suppression of
stdoutandstderrfor various Git commands in theGitRepoclass and thehost-os-release-notes.pyscript. This includes commands such ascheckout,fetch, andreset, which now will output their standard messages and errors to the console.Impact: