fix: difference in Cargo.lock for ic0 package
#1205
Merged
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
NikolaMilosa
changed the title
Cargo.lock for ic0 package
LittleChimera
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a long running issue of difference of running the following commands that lock the
ic0package differently:cargo check # vs bazel build ...It can also happen if the code editor runs an lsp with some different arguments by default.
With this change we always lock against crates-io version since that is what is used when doing
bazel build. In theory this should be resolved in upstream packages but for now this should do. The github version is being updated along with other github deps when we upgrade crate versions meaning that all compilation errors will be caught there.Changes like this should no longer happen:
