feat: offboard nodes in GE1 DC #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary - Adds new entries for `node_id` under `cordoned_features.yaml` to document offboarding of nodes in the GE1 data center. - Rearranges enum variants in `NodeFeature` within `rs/ic-management-types/src/lib.rs`, specifically adding `NodeId` and reordering `NodeProvider` and `NodeOperator`. ### Changes - **cordoned_features.yaml:** - Introduced several `node_id` entries, each detailing the offboarding of nodes based on forum discussion references. - **lib.rs** - Added `NodeId` to the key-value pairs for `Node` feature mapping. - Updated the `NodeFeature` enum to include `NodeId` and adjusted the enum variant order. - Modified the feature filtering method to exclude `node_id` entries along with existing exclusions. ### Additional notes - Adjustments address feature alignment and documentation consistency for node management.
NikolaMilosa
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cordoned Features Update:
node_identries incordoned_features.yamlfor offboarding the second rack of nodes in the GE1 DC, linking to relevant forum proposals for reference.Code Enhancements in
rs/ic-management-types:NodeFeature::NodeIdto the node features serialization list to ensure inclusion.NodeFeatureenum and adjusted related logic to filter outnode_idfrom specific processes.