Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence to MSD definitions #169

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Feb 7, 2024

The following add networks-state-file arg which will store MSD definitions.
Usage:
--networks-state-file /tmp/def/def.json
https://dfinity.atlassian.net/browse/OB-496.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 7, 2024 10:24
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Load and Store definitions from/to disk Add persistence to MSD definitions Feb 7, 2024
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think having it as "opt-in" is the best for now. Thanks!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 7, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity removed this pull request from the merge queue due to a manual request Feb 7, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 7, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 73ac4cf Feb 7, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the add-persistence-msd branch February 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants