Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist definitions to disk on add/remove #192

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

  • Change the way we persist definitions to disks to rewrite them every time we add/remove definitions from the server

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 13, 2024 15:46
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That was super quick!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 13, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity removed this pull request from the merge queue due to a manual request Feb 13, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 18, 2024
Merged via the queue into main with commit d605561 Feb 18, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the persist-definition-to-disk branch February 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants