Introduce interrupt and retry handling to initial definition sync. #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been quite good with regards to handling interrupts / SIGTERMs almost from the very start in MSD. However, a small oversight with regards to initial sync caused #314 , which in turn causes the daemon to freeze upon shutdown if any definition failed its initial sync. The root cause is that the thread terminates on its own, not polling its end of the ender channel used to shut it down. This PR fixes the issue. In addition to that, we now also retry initial syncs just as failed incremental syncs are retried. This adds robustness in the face of temporary network outages just as MSD is starting to execute.
|
Applying Cargo demands to codebase. Will soon merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been quite good with regards to handling interrupts / SIGTERMs almost from the very start in MSD. However, a small oversight with regards to initial sync caused #314 , which in turn causes the daemon to freeze upon shutdown if any definition failed its initial sync. The root cause is that the thread terminates on its own, not polling its end of the ender channel used to shut it down.
This PR fixes the issue.
In addition to that, we now also retry initial syncs just as failed incremental syncs are retried. This adds robustness in the face of temporary network outages just as MSD is starting to execute.