Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dre): not displaying sensitive pin when running help command #453

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

NikolaMilosa
Copy link
Contributor

Before:

dre --help                                                               
 INFO  dre > Running version 0.4.0-9f8fa09
 INFO  dre > Binary up to date.
Tooling for managing the Internet Computer

Usage: dre [OPTIONS] <COMMAND>

Commands:
  der-to-principal         
  subnet                   Manage an existing subnet
  get                      Get a value using ic-admin CLI
  propose                  Place a proposal using the ic-admin CLI
  update-unassigned-nodes  Place a proposal for updating unassigned nodes config
  version                  Manage replica/host-os versions blessing
  hostos                   Rollout hostos version
  nodes                    Manage nodes
  vote                     Vote on our proposals
  trustworthy-metrics      Trustworthy Metrics
  registry                 Registry inspection (dump) operations
  firewall                 Firewall rules
  proposals                Proposal Listing
  help                     Print this message or the help of the given subcommand(s)

Options:
      --hsm-pin <HSM_PIN>                  [env: HSM_PIN=123456]
      --hsm-slot <HSM_SLOT>                [env: HSM_SLOT=0]
      --hsm-key-id <HSM_KEY_ID>            [env: HSM_KEY_ID=0]
      --private-key-pem <PRIVATE_KEY_PEM>  [env: PRIVATE_KEY_PEM=]
      --neuron-id <NEURON_ID>              [env: NEURON_ID=]
      --ic-admin <IC_ADMIN>                [env: IC_ADMIN=]
      --dev                                [env: DEV=]
  -y, --yes                                [env: YES=]
      --simulate                           
      --verbose                            [env: VERBOSE=]
      --network <NETWORK>                  [env: NETWORK=] [default: mainnet]
      --nns-urls <NNS_URLS>                [env: NNS_URLS=]
  -h, --help                               Print help
  -V, --version                            Print version

After:

dre --help                                                                    
 INFO  dre > Running version 0.4.0-9f8fa09-dirty
 INFO  dre > Binary up to date.
Tooling for managing the Internet Computer

Usage: dre [OPTIONS] <COMMAND>

Commands:
  der-to-principal         
  subnet                   Manage an existing subnet
  get                      Get a value using ic-admin CLI
  propose                  Place a proposal using the ic-admin CLI
  update-unassigned-nodes  Place a proposal for updating unassigned nodes config
  version                  Manage replica/host-os versions blessing
  hostos                   Rollout hostos version
  nodes                    Manage nodes
  vote                     Vote on our proposals
  trustworthy-metrics      Trustworthy Metrics
  registry                 Registry inspection (dump) operations
  firewall                 Firewall rules
  proposals                Proposal Listing
  help                     Print this message or the help of the given subcommand(s)

Options:
      --hsm-pin <HSM_PIN>                  [env: HSM_PIN]
      --hsm-slot <HSM_SLOT>                [env: HSM_SLOT=0]
      --hsm-key-id <HSM_KEY_ID>            [env: HSM_KEY_ID=0]
      --private-key-pem <PRIVATE_KEY_PEM>  [env: PRIVATE_KEY_PEM=]
      --neuron-id <NEURON_ID>              [env: NEURON_ID=]
      --ic-admin <IC_ADMIN>                [env: IC_ADMIN=]
      --dev                                [env: DEV=]
  -y, --yes                                [env: YES=]
      --simulate                           
      --verbose                            [env: VERBOSE=]
      --network <NETWORK>                  [env: NETWORK=] [default: mainnet]
      --nns-urls <NNS_URLS>                [env: NNS_URLS=]
  -h, --help                               Print help
  -V, --version                            Print version

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner June 4, 2024 14:25
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sasa-tomic sasa-tomic merged commit e16b578 into main Jun 4, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the nm-sensitive-info branch June 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants